Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify when method implementation #6721

Merged
merged 8 commits into from
May 9, 2024
Merged

Conversation

assert6
Copy link
Member

@assert6 assert6 commented Apr 28, 2024

No description provided.

huangdijia
huangdijia previously approved these changes Apr 28, 2024
@huangdijia huangdijia changed the title 统一when 方法实现 Unify when method implementation Apr 28, 2024
huangdijia
huangdijia previously approved these changes Apr 28, 2024
@limingxinleo
Copy link
Member

抽空看看补几个测试

@limingxinleo
Copy link
Member

PR 看看,明晚或者节后处理

* @param callable($this): $this $callback
* @param $this|callable($this): null $default
* @param callable($this, $value): $this $callback
* @param callable($this, $value): $this $default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$default 返回的不是 $this 吧?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和callback 一样的逻辑

@limingxinleo limingxinleo merged commit c3c36ea into hyperf:master May 9, 2024
61 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants