Enable ppc64le support #345
Conversation
|
Can one of the admins verify this patch? |
build/make-kernel.sh
Outdated
| if [ $ARCH == "ppc64le" ] | ||
| then | ||
| docker build -t hyperstart-dev-$ARCH:latest -f Dockerfile . | ||
| docker run --rm hyperstart-dev-$ARCH:latest cat /root/build/result/kernel >kernel.new && mv -f kernel.new $ARCHPATH/kernel |
There was a problem hiding this comment.
If using hyper to build the kernel is workable after bootstrapped on ppc64le, please use hyper. Otherwise, could you please report the issue about it?
docker or manual-build is allowed to be used anytime for the same purpose, especially when bootstrapping or when some problem occurring. But merging the kernel-building code using docker is not encouraged.
There was a problem hiding this comment.
@laijs Right now hyper is not a workable solution because hyper has not been ported to ppc64le yet. I can understand your concerns about having a code that explicitly uses docker, but on architectures where hyper is not yet available there is no other choice.
Would it make sense if I push a README instead of the code change? That way our users won't be left to guessing on how to build a kernel. Of course, this might change if hyper ported to ppc64le, but till then I believe there has to be a way to communicate with the users to use docker.
What do you say?
There was a problem hiding this comment.
The built kernel will be included after this PR is merged. Any other want to use hyper on ppc64le can use the kernel and the other ppc64le code in this PR directly. kernel-build via hyper on ppc64le should be workable after this pr merged.
They don't really need to do the bootstrapping on ppc64le.
I know hyper is not a workable solution before this pr is merged. But the hyper ppc64le is only actived after this pr is merged. And every thing should be workable after this pr is merged, including hyper and hyper-build and hyper-kernel-build.
Any one who need to do the bootstrapping should use manual-build or docker.
I don't mind you push some document for the bootstrapping for the porting. But we are also in development in a new build system. The next porting might use the new build system.
There was a problem hiding this comment.
Ok, for now, I will update this PR by dropping the kernel build code. Thanks for your inputs.
There was a problem hiding this comment.
Thanks. And if there is any problem for the hyper-kernel-build on ppc64le after this pr merged, don't hesitate to report it.
Signed-off-by: Harshal Patil <harshal.patil@in.ibm.com>
|
@laijs I have updated PR as per our discussion. |
|
Thanks! |
This PR adds support for hyperstart on
ppc64learchitecture.runv hot plugs the NIC after VM is booted. In
ppc64leRTAS daemon enables this feature for the VM. This patch adds RTAS related libs in initrd forppc64learchitecture.Signed-off-by: Harshal Patil harshal.patil@in.ibm.com