Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check fork-choice rule implementation when forked block is outside of window #22

Closed
sbazerque opened this issue Jul 11, 2021 · 4 comments

Comments

@sbazerque
Copy link
Member

I think there may be a mistake on the filtering of gossip or in the rule itself, saw a failing example in a small testnet.

@jio-gl
Copy link
Collaborator

jio-gl commented Jul 12, 2021

Ok, maybe is a border case in the limit of the finality window? We can later change the name from Finality Depth to Finality Window, sounds like the later name stuck up more.

@sbazerque
Copy link
Member Author

The problem turned out to be in HHS' networking code - tested fork choice outside the window and everything seems to work fine.

@jio-gl
Copy link
Collaborator

jio-gl commented Jul 14, 2021

Perfect @sbazerque.

@jio-gl
Copy link
Collaborator

jio-gl commented Jul 14, 2021

Great news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants