Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Cleanups #1075

Merged
merged 44 commits into from Nov 14, 2020
Merged

Various Cleanups #1075

merged 44 commits into from Nov 14, 2020

Conversation

Lord-Grey
Copy link
Collaborator

Summary

This PR addresses various findings raised by static code analysis, e.g. lgtm, clang and compile warnings
and related code-updates required.

Added

  • LED-device discovery: support of passing additional parameters

Changes

Fixes

  • Fix multiple spelling issues within the code
  • Fix static Code-analysis findings
  • Fix Hyperion configuration is corrected during start-up, if required

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@Lord-Grey Lord-Grey self-assigned this Nov 2, 2020
@Lord-Grey Lord-Grey added this to Backlog in Output Devices via automation Nov 2, 2020
@Lord-Grey Lord-Grey moved this from Backlog to In Progress in Output Devices Nov 2, 2020
@Lord-Grey Lord-Grey added this to In Progress in Input Devices Nov 2, 2020
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Lord-Grey Lord-Grey mentioned this pull request Nov 7, 2020
1 task
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Lord-Grey Lord-Grey merged commit efc2046 into hyperion-project:master Nov 14, 2020
Input Devices automation moved this from In Progress to Done Nov 14, 2020
Output Devices automation moved this from In Progress to Done Nov 14, 2020
Core automation moved this from In Progress to Done Nov 14, 2020
@Lord-Grey Lord-Grey deleted the cleanups branch November 14, 2020 16:59
@Lord-Grey Lord-Grey moved this from In Progress to Done in Web UI Jan 17, 2021
@Lord-Grey Lord-Grey moved this from In Progress to Done in API Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
API
  
Done
Core
  
Done
Input Devices
  
Done
Web UI
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants