Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Workaround set-music error when music is already off #1379

Merged
merged 3 commits into from Dec 14, 2021

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Nov 21, 2021

Summary

Fixed

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Fixes #1372

@Lord-Grey Lord-Grey self-assigned this Nov 21, 2021
@Lord-Grey Lord-Grey added this to Backlog in Output Devices via automation Nov 21, 2021
@Lord-Grey Lord-Grey moved this from Backlog to Done in Output Devices Nov 21, 2021
@Lord-Grey Lord-Grey moved this from Done to In Progress in Output Devices Nov 21, 2021
@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm the Hyperion Project Bot and I want to thank you for
contributing to Hyperion with your pull requests!

To help you and other users test your pull requests faster,
I'll create a link for you to your workflow artifacts.

🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1487571477

Of course, if you make changes to your PR, I will create a new link.

Best regards,
Hyperion Project

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1487598834

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1496502065

@Lord-Grey Lord-Grey merged commit 442fab9 into hyperion-project:master Dec 14, 2021
Output Devices automation moved this from In Progress to Done Dec 14, 2021
@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1576566080

@Lord-Grey Lord-Grey deleted the Fix_#1372 branch February 21, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Yeelight 1S LED-Output not turning on correctly
1 participant