Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mbed TLS 3.3.0 #1558

Merged
merged 4 commits into from
Feb 5, 2023
Merged

Conversation

Lord-Grey
Copy link
Collaborator

Summary

  • Update to Mbed TLS 3.3.0

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@Lord-Grey Lord-Grey self-assigned this Jan 16, 2023
@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm the Hyperion Project Bot and I want to thank you for
contributing to Hyperion with your pull requests!

To help you and other users test your pull requests faster,
I'll create a link for you to your workflow artifacts.

🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3933512687

Of course, if you make changes to your PR, I will create a new link.

Best regards,
Hyperion Project

@Lord-Grey Lord-Grey added this to In Progress in Core Jan 16, 2023
@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3947094640

@Lord-Grey Lord-Grey merged commit ef7ceb0 into hyperion-project:master Feb 5, 2023
Core automation moved this from In Progress to Done Feb 5, 2023
asturel pushed a commit to asturel/hyperion.ng that referenced this pull request Feb 11, 2023
* Convert mbedtls to subproject

* Align cmake to subproject and mbedtls 3.3.0

* mdebtls 3.3.0

* Add cxx_std_20 for Windows build
@adlerweb
Copy link

Just to be sure: Was it intentional to set https://github.com/Lord-Grey/hyperion.ng/blob/00f476eb53ad5963ec2573ba43c2c4c8c38af93d/.gitmodules#L17 to a local file path instead of a repository URL like https://github.com/Mbed-TLS/mbedtls?

@Lord-Grey
Copy link
Collaborator Author

Just to be sure: Was it intentional to set https://github.com/Lord-Grey/hyperion.ng/blob/00f476eb53ad5963ec2573ba43c2c4c8c38af93d/.gitmodules#L17 to a local file path instead of a repository URL like https://github.com/Mbed-TLS/mbedtls?

Yes. We changed the MBedTLS code integration using GItHub submodule.
Previously, latest code was downloaded during the builds, but too often it failed which required to have a dedicated version fixed.

@Lord-Grey Lord-Grey deleted the mbedtls branch February 16, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants