Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #883 -DUSE_SYSTEM_MBEDTLS_LIBS=ON - undefined reference #898

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

SJunkies
Copy link
Contributor

@SJunkies SJunkies commented Jul 23, 2020

Summary

Fixes: #883

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @SJunkies 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@SJunkies SJunkies changed the title Fix: -DUSE_SYSTEM_MBEDTLS_LIBS=ON - undefined reference Fixes: #883 -DUSE_SYSTEM_MBEDTLS_LIBS=ON - undefined reference Jul 23, 2020
@Paulchen-Panther
Copy link
Member

@SJunkies Ready?

@SJunkies
Copy link
Contributor Author

@Paulchen-Panther
I haven't received any feedback from @mirko, but yes it's done...

@Paulchen-Panther
Copy link
Member

OK. mirko will contact you if it doesn't work 😁

@Paulchen-Panther Paulchen-Panther merged commit 3749453 into hyperion-project:master Jul 27, 2020
@mirko
Copy link
Contributor

mirko commented Aug 2, 2020

I'm sorry for being unresponsive and not providing the full log as asked in the issue. I'm happy to say, though, that using mbdtls system libs indeed now works for me - thanks a lot!

@SJunkies SJunkies deleted the issue883Fix branch August 3, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When building with -DUSE_SYSTEM_MBEDTLS_LIBS=ON hyperion doesn't get linked against shared objects
3 participants