Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on language elements #916

Merged
merged 19 commits into from
Aug 3, 2020
Merged

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Jul 27, 2020

Summary
Updates language elements...

Fix

  • Correct typo in language selection

Changes

  • Sort Languages alphabetically
  • Merge DE translations with DE ones in POEditor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Lord-Grey Lord-Grey changed the title Minor updates on language elements Updates on language elements Jul 27, 2020
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@brindosch
Copy link
Contributor

Did you merged the POEditor translations over the repo translations? The POEditor translations for DE aren't that mature or in sync with later repo updates?

@Lord-Grey
Copy link
Collaborator Author

Lord-Grey commented Aug 3, 2020

Did you merged the POEditor translations over the repo translations? The POEditor translations for DE aren't that mature or in sync with later repo updates?

@brindosch

  1. I downloaded POEditor DE as json
  2. I downloaded DE.json
  3. I sorted both files per element
  4. I compared each element one by one and chosen the latest/better translation
  5. I checked in the merged file in Git
  6. I uploaded the merged file into POEditor

i.e. I did a two way manual merge, currently both files should now be in sync.

btw. I saw that there is a Git Plugin in POEditor, but seems to limited rights I cannot see additional options for configuration.
Maybe worth a try, given that there was a reasonable number of mismatches.

@brindosch
Copy link
Contributor

brindosch commented Aug 3, 2020

Thank you for clarification. Just wanted to make sure we don't trash strings :)

btw. I saw that there is a Git Plugin in POEditor

Do you mean "Integrations" Github? It's just for syncing and the options are very limited.

@brindosch brindosch merged commit 11d7614 into hyperion-project:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants