Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket fix for SSL reverse proxies #924

Merged
merged 2 commits into from
Aug 2, 2020

Conversation

m33ts4k0z
Copy link
Contributor

@m33ts4k0z m33ts4k0z commented Aug 1, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Fixes #924

@hyperion-project
Copy link

Hello @m33ts4k0z 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@Lord-Grey
Copy link
Collaborator

@m33ts4k0z Great that looks good. Thank you!
Did you test it and does it resolve the reverse proxy issue at your end?

In addition, you now have a way to further help improving hyperion :)

@m33ts4k0z
Copy link
Contributor Author

@Lord-Grey Yes I run it like that now on my Rpi3 :) it took some time to compile but it works fine. I have even posted a working Nginx configuration in the issue thread :). Thanks for your great work too. I will be around ;)

@Lord-Grey Lord-Grey linked an issue Aug 1, 2020 that may be closed by this pull request
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@brindosch
Copy link
Contributor

This is my bad, i forgot to add the default ssl port. Thanks for fixing

@brindosch brindosch merged commit d1a2b77 into hyperion-project:master Aug 2, 2020
Lord-Grey pushed a commit to Lord-Grey/hyperion.ng that referenced this pull request Aug 4, 2020
* Websocket fix for SSL reverse proxies

* docs: add changelog

Co-authored-by: Sersch <edeltraud70@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse proxy with SSL not working with Hyperion.ng
3 participants