Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between LED-Device Enable/Disable and Switch On/Off #960

Merged
merged 10 commits into from
Sep 14, 2020

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Aug 9, 2020

Summary

Differentiate between LED-Device Enable/Disable and Switch On/Off allows to
switch off LED-Devices output when there is no signal e.g. given no source is available any longer.
In case input is available again, LED-Devices are switched on.
In both cases, the LED-Device shows enabled allowing to differentiate from error state or a suspend/resume scenario.

Currently, switch on/off is implemented, if no source is available (addressing #828).

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)

image

  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Fixes: #828

@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@gogui63
Copy link

gogui63 commented Aug 21, 2020

Any news when that will be merged into master?

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

1 similar comment
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther
Copy link
Member

@Lord-Grey Is the PR done so far?

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Lord-Grey
Copy link
Collaborator Author

Yes, Let us merge the PR now.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther Paulchen-Panther merged commit 4aabe17 into hyperion-project:master Sep 14, 2020
@Lord-Grey Lord-Grey added this to Done in Output Devices Sep 23, 2020
@Lord-Grey Lord-Grey deleted the expose_switchOnOff branch October 12, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

LEDs are not turning black after deactivating Protocol Buffers Stream and no active source is left
3 participants