Fix for invalid header panic corrected #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake_request` function return a Result" This reverts commit 66c36c4.
… pseudo-header in the informational range of status codes Signed-off-by: Michael Rodler <mrodler@amazon.de> Co-Authored-By: f0rki <m@mrodler.eu> Reviewed-by: Daniele Ahmed <ahmeddan@amazon.de>
f0rki
changed the title
82marbag
reviewed
Jun 15, 2023
82marbag
reviewed
Jun 16, 2023
Co-authored-by: 82marbag <69267416+82marbag@users.noreply.github.com>
f0rki
force-pushed
the
invalid-header-panic-corrected
branch
from
a528d64
to
07397f4
Compare
f0rki
force-pushed
the
invalid-header-panic-corrected
branch
from
07397f4
to
54f965a
Compare
seanmonstar
reviewed
Jun 16, 2023
seanmonstar
approved these changes
Jun 22, 2023
0xE282B0
pushed a commit
to 0xE282B0/h2
that referenced
this pull request
Jan 11, 2024
* Revert "fix panic on receiving invalid headers frame by making the `take_request` function return a Result" This reverts commit 66c36c4. * proper fix for the panic in server receiving a request with a :status pseudo-header in the informational range of status codes --------- Signed-off-by: Michael Rodler <mrodler@amazon.de> Co-authored-by: Michael Rodler <mrodler@amazon.de> Co-authored-by: Daniele Ahmed <ahmeddan@amazon.de>
0xE282B0
pushed a commit
to 0xE282B0/h2
that referenced
this pull request
Jan 11, 2024
* Revert "fix panic on receiving invalid headers frame by making the `take_request` function return a Result" This reverts commit 66c36c4. * proper fix for the panic in server receiving a request with a :status pseudo-header in the informational range of status codes --------- Signed-off-by: Michael Rodler <mrodler@amazon.de> Co-authored-by: Michael Rodler <mrodler@amazon.de> Co-authored-by: Daniele Ahmed <ahmeddan@amazon.de>
0xE282B0
pushed a commit
to 0xE282B0/h2
that referenced
this pull request
Jan 16, 2024
* Revert "fix panic on receiving invalid headers frame by making the `take_request` function return a Result" This reverts commit 66c36c4. * proper fix for the panic in server receiving a request with a :status pseudo-header in the informational range of status codes --------- Signed-off-by: Michael Rodler <mrodler@amazon.de> Co-authored-by: Michael Rodler <mrodler@amazon.de> Co-authored-by: Daniele Ahmed <ahmeddan@amazon.de> Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected fix in #690 - the root cause was that informational header frames are ignored, even if received by the server. However, the stream was still scheduled in
pending_accept. This then triggers thetake_request, while nothing is put in thepending_recvqueue, which then causes the panic.