h2 server panics when receiving headers that look like response #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2023 15:37
…est` function return a Result Signed-off-by: Michael Rodler <mrodler@amazon.de> Reviewed-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Michael Rodler <mrodler@amazon.de> Reviewed-by: Daniele Ahmed <ahmeddan@amazon.de>
f0rki
force-pushed
the
invalid-header-panic
branch
from
bf02d78
to
cdc417d
Compare
seanmonstar
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending a response frame to an
h2server triggers a panic. this PR makes thetake_requestfunction return a Result instead of panicking.