Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit public API types for drop impls #95

Closed
carllerche opened this issue Sep 18, 2017 · 2 comments
Closed

Audit public API types for drop impls #95

carllerche opened this issue Sep 18, 2017 · 2 comments

Comments

@carllerche
Copy link
Collaborator

carllerche commented Sep 18, 2017

All public API types should be audited to see if they need a Drop impl to maintain correct state.

Current known issues:

@carllerche carllerche added this to the v0.1 milestone Sep 18, 2017
@carllerche carllerche removed this from the v0.1 milestone Jan 3, 2018
@carllerche
Copy link
Collaborator Author

This does not require API breakage. So I will remove it from the 0.1 milestone.

@nox
Copy link
Contributor

nox commented Apr 29, 2021

Stream, Body, SendResponse, ResponseFuture, SendStream and RecvStream all transitively wrap an OpaqueStreamRef that cleans up after itself in its Drop impl, AFAIK this can be closed now.

@nox nox closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants