Refactor errors (fixes #530) #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
force-pushed
the
errors
branch
4 times, most recently
from
48eb28f
to
c755975
Compare
LPardue
reviewed
Aug 31, 2021
ipostelnik
reviewed
Aug 31, 2021
nox
force-pushed
the
errors
branch
7 times, most recently
from
fcdcd3b
to
f8ccae8
Compare
|
Seems like there are no tests for resets, will check that out. |
nox
force-pushed
the
errors
branch
15 times, most recently
from
d058cb7
to
276b1e2
Compare
seanmonstar
reviewed
Sep 10, 2021
src/error.rs
Outdated
| Kind::GoAway(ref debug_data, reason, initiator) => { | ||
| write!(fmt, "go away from {}: {}", initiator, reason)?; | ||
| if !debug_data.is_empty() { | ||
| write!(fmt, " ({:?})", debug_data)?; |
There was a problem hiding this comment.
Should we be including the debug data in the Display implementation? It might be useful, or it could be complete junk. Maybe we should, but also maybe it should only be showed in Debug...
There was a problem hiding this comment.
We use Display and it's a bit bothersome to use Debug for one specific error.
What about Display but only the alternate format?
There was a problem hiding this comment.
Hm. Alternate output might be a good use here... Do you know what other HTTP/2 libraries do with the debug-data? Like netty, or grpc, or other...?
There was a problem hiding this comment.
@seanmonstar Let's merge it? 🥺
nox
force-pushed
the
errors
branch
2 times, most recently
from
09909f5
to
77969a6
Compare
|
The errors are fixed by #557. |
h2::Error now knows whether protocol errors happened because the user sent them, because it was received from the remote peer, or because the library itself emitted an error because it detected a protocol violation. It also keeps track of whether it came from a RST_STREAM or GO_AWAY frame, and in the case of the latter, it includes the additional debug data if any.
seanmonstar
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h2::Error now knows whether protocol errors happened because the user
sent them, because it was received from the remote peer, or because
the library itself emitted an error because it detected a protocol
violation.
It also keeps track of whether it came from a RST_STREAM or GO_AWAY
frame, and in the case of the latter, it includes the additional
debug data if any.