Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for a fuzzer-discovered integer underflow of the flow control window size #692

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix for a fuzzer-discovered integer underflow of the flow control window size #692

merged 2 commits into from
Jun 26, 2023

Commits on Jun 13, 2023

  1. Fix for a fuzzer-discovered integer underflow of the flow control win… 

    …dow size

Removed the SubAssign, etc. syntactic sugar functions and switched to return Result on over/underflow

Whenever possible, switched to returning a library GoAway protocol
error. Otherwise we check for over/underflow only with `debug_assert!`,
assuming that those code paths do not over/underflow.

Signed-off-by: Michael Rodler <mrodler@amazon.de>
Co-Authored-By: f0rki <m@mrodler.eu>
Reviewed-by: Daniele Ahmed <ahmeddan@amazon.de>
    @f0rki
    Michael Rodler and f0rki committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    eb10db0 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Fix function call 

    Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
    @82marbag
    82marbag authored and Daniele Ahmed committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    7489b37 View commit details
    Browse the repository at this point in the history