Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: early server response with data #703

Merged

Conversation

DDtKey
Copy link
Contributor

@DDtKey DDtKey commented Jul 21, 2023

This is normal scenario and I decided to extend test a bit.

- fix of the test's name after changing it in hyperium#634
- additional test that server also sends data frames correctly
@DDtKey
Copy link
Contributor Author

DDtKey commented Jul 21, 2023

And also this is preliminary change to handle NO_ERROR correctly on client side in (h2 or hyper` - ?), because currently such case causes:

hyper::Error(Body, Error { kind: Reset(StreamId(3), NO_ERROR, Remote) }

While request was handled correctly (for example, reaching max request body size) and the response was sent.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@seanmonstar seanmonstar merged commit 46fb80b into hyperium:master Jul 22, 2023
6 checks passed
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this pull request Jan 11, 2024
- fix of the test's name after changing it in hyperium#634
- additional test that server also sends data frames correctly
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this pull request Jan 11, 2024
- fix of the test's name after changing it in hyperium#634
- additional test that server also sends data frames correctly
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this pull request Jan 16, 2024
- fix of the test's name after changing it in hyperium#634
- additional test that server also sends data frames correctly

Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants