fix: stream flow control insufficient size before ack #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Feb 1, 2024
seanmonstar
approved these changes
Feb 2, 2024
seanmonstar
pushed a commit
that referenced
this pull request
Mar 15, 2024
Closed
seanmonstar
pushed a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #630
This PR makes the Recv stream use the default window size before receiving ACK from the other party.
This matters as a server when we want the stream
initial_window_size<= default settings. In some cases, the client will eagerly send some data frames before ACK-ing settings, thus resulting in a flow control error if the size of data frames is greater than the setinitial_window_size.