Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityTag type is private #49

Closed
jdm opened this issue Oct 15, 2019 · 3 comments · Fixed by #64
Closed

EntityTag type is private #49

jdm opened this issue Oct 15, 2019 · 3 comments · Fixed by #64

Comments

@jdm
Copy link

jdm commented Oct 15, 2019

For implementations like Servo that are implementing an HTTP cache, it would be nice to reuse the ETag machinery that already exists in this repository. Right now it's impossible to do anything with the typed ETag header and we need to reimplement the weak/strong comparisons.

@seanmonstar
Copy link
Member

Yea, I'd be happy to add to the API! Is there need for the internal EntityTag, or can we just make the related headers accept an &Etag?

@jdm
Copy link
Author

jdm commented Oct 15, 2019

I don't think there's any particular need for the internal type.

@jakelee8
Copy link

jakelee8 commented Mar 9, 2023

EntityTag is still private for v0.3.8: https://github.com/hyperium/headers/blob/master/src/util/entity.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants