Empty frame cause panic

[chrislearn]

http-body/http-body-util/src/collected.rs

Line 44 in 619ba28

self.bufs.push(data);

http-body/http-body-util/src/util.rs

Line 14 in 619ba28

debug_assert!(buf.has_remaining());

When frame is empty, this cause panic, just wondering if this is expected behavior?
Some HTTP/2 implementations may product empty frames, when I create a reverse proxy server，and call body.collect().await.to_bytes() to read data, server will give error in debug mode. Or just give a warning here?

[seanmonstar]

The collect combinator should probably filter out the empty data frames, to prevent the panic.

[chrislearn]

http-body/http-body-util/src/collected.rs

Lines 41 to 48 in 619ba28

	pub(crate) fn push_frame(&mut self, frame: Frame<B>) {
	let frame = match frame.into_data() {
	Ok(data) => {
	self.bufs.push(data);
	return;
	}
	Err(frame) => frame,
	};

In push_frame, just push data to bufs and does not check is data is empty.

http-body/http-body-util/src/combinators/collect.rs

Lines 25 to 43 in 619ba28

	impl<T: Body + ?Sized> Future for Collect<T> {
	type Output = Result<crate::Collected<T::Data>, T::Error>;
	fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> std::task::Poll<Self::Output> {
	let mut me = self.project();
	loop {
	let frame = futures_util::ready!(me.body.as_mut().poll_frame(cx));
	let frame = if let Some(frame) = frame {
	frame?
	} else {
	return Poll::Ready(Ok(me.collected.take().expect("polled after complete")));
	};
	me.collected.as_mut().unwrap().push_frame(frame);
	}
	}
	}

In Collect's poll function, call push_frame directly and push the frame.

[meowjesty]

Hi what's the status on this? Anyone working on adding this change?

Had to make this change for our project, can send a PR if no one is working on this.

[davidpdrsn]

No I don't think anyone is working on it. You're welcome to submit a PR.

[aviramha]

Hey, we'd love to use an officially released version. Is it possible to please create a release? @seanmonstar