Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TryFrom Parts for Uri has a Error type that can never occur #112

Closed
seanmonstar opened this issue Aug 15, 2017 · 2 comments
Closed

TryFrom Parts for Uri has a Error type that can never occur #112

seanmonstar opened this issue Aug 15, 2017 · 2 comments
Milestone

Comments

@seanmonstar
Copy link
Member

The current implementation has type Error = InvalidUri, but this can never occur.

If we decide that #96 should be changed or removed, then this could be updated to correctly return an InvalidUri error.

If not, we might want to consider that a From<T> will likely end up in a TryFrom<T> where Error = ! blanket impl. Can we have some uninhabited type in convert.rs as the Error, and then alias it to bang or something later?

@seanmonstar seanmonstar added this to the 0.1 milestone Aug 15, 2017
@carllerche
Copy link
Collaborator

Handled by #114

@carllerche
Copy link
Collaborator

Fixed by #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants