Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is uri::Parts -> Uri fallible? #96

Closed
carllerche opened this issue Aug 3, 2017 · 2 comments
Closed

Is uri::Parts -> Uri fallible? #96

carllerche opened this issue Aug 3, 2017 · 2 comments
Milestone
0.1

Comments

@carllerche
Copy link
Collaborator

There currently is an Into implementation, but I believe that there may be be error cases. If so, the impl should be removed.
@carllerche carllerche added this to the 0.1 milestone Aug 3, 2017
@carllerche carllerche mentioned this issue Aug 3, 2017
Merged
@seanmonstar
Copy link
Member

Currently, the error cases hit asserts. This makes sense if you've received a Parts from an existing Uri... Is that supposed to be the only way you would have gotten one, anyways?

@seanmonstar seanmonstar mentioned this issue Aug 15, 2017
Closed
@carllerche
Copy link
Collaborator Author

No, h2 constructs a Uri from Parts. It seems like this should be switched to be fallible.

carllerche added a commit that referenced this issue Aug 16, 2017
@carllerche
Uri conversion from Parts is fallible
bf42709 
Fixes #96
@carllerche carllerche mentioned this issue Aug 16, 2017
Merged
carllerche added a commit that referenced this issue Aug 16, 2017
@carllerche
Uri conversion from Parts is fallible
14a70ed 
Fixes #96
carllerche added a commit that referenced this issue Aug 16, 2017
@carllerche
Uri conversion from Parts is fallible (#114)
8f62fc6 
Fixes #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@carllerche @seanmonstar