Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Bytes to the public API again #459

Open
tesaguri opened this issue Dec 31, 2020 · 1 comment · May be fixed by #470
Open

Expose Bytes to the public API again #459

tesaguri opened this issue Dec 31, 2020 · 1 comment · May be fixed by #470

Comments

@tesaguri
Copy link
Contributor

http is using the stable version of bytes crate now (#457) so I guess #369 can be reverted, except for the addition of from_maybe_shared constructors until http v0.3 or v1.0.
@dekellum
Copy link
Contributor

dekellum commented Dec 31, 2020 •
edited
Loading

What would be the motivation or advantage to reverting all or part of #369? I mean, 4ce5e6a was released in 0.2.0-0.2.3, so such would be a visible change in 0.2.4 (if such a patch release is ever even made). I find in general, that its a strength that dependencies that don't need to be public, are kept private.

tesaguri added a commit to tesaguri/http that referenced this issue Mar 9, 2021
@tesaguri
Bring back TryFrom<Bytes> implementations
000c9dd 
This is mostly a revert of commit
4ce5e6a, but this does not bring back
the error variants suffixed with `Bytes`
(db9b1b9).

This also replaces usage of the internal `from_shared` associated
functions with `try_from`.

Reference: <hyperium#459>
@tesaguri tesaguri linked a pull request Mar 9, 2021 that will close this issue
Open
tesaguri added a commit to tesaguri/http that referenced this issue Jul 18, 2021
@tesaguri
Bring back TryFrom<Bytes> implementations
8edb94c 
This is mostly a revert of commit
4ce5e6a, but this does not bring back
the error variants suffixed with `Bytes`
(db9b1b9).

This also replaces usage of the internal `from_shared` associated
functions with `try_from`.

Closes <hyperium#459>.
tesaguri added a commit to tesaguri/http that referenced this issue May 2, 2022
@tesaguri
Bring back TryFrom<Bytes> implementations
875cdfa 
This is mostly a revert of commit
4ce5e6a, but this does not bring back
the error variants suffixed with `Bytes`
(db9b1b9).

This also replaces usage of the internal `from_shared` associated
functions with `try_from`.

Closes <hyperium#459>.
tesaguri added a commit to tesaguri/http that referenced this issue Aug 12, 2023
@tesaguri
feat: bring back TryFrom<Bytes> implementations
22171ed 
This is mostly a revert of commit
4ce5e6a, but this does not bring back
the error variants suffixed with `Bytes`
(db9b1b9).

This also replaces usage of the internal `from_shared` associated
functions with `try_from`.

Closes <hyperium#459>.
@tesaguri tesaguri mentioned this issue Aug 12, 2023
Closed
This was referenced Aug 29, 2023
Open
Closed
@tesaguri tesaguri mentioned this issue Dec 30, 2023
Open
tesaguri added a commit to tesaguri/http that referenced this issue Feb 14, 2024
@tesaguri
feat: bring back TryFrom<Bytes> implementations
44eb611 
This is mostly a revert of commit
4ce5e6a, but this does not bring back
the error variants suffixed with `Bytes`
(db9b1b9).

This also adds `HeaderValue::from_shared_unchecked` constructor, which
corresponds to the `from_maybe_shared_unchecked` constructor, and
replaces usage of the internal `from_shared` associated functions with
`try_from`.

Closes <hyperium#459>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: bring back TryFrom<Bytes> implementations tesaguri/http
2 participants
@dekellum @tesaguri