Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): implement Clone for GracefulShutdown #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(server): implement Clone for GracefulShutdown #136

wants to merge 1 commit into from

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Jul 10, 2024 •
edited
Loading

Implements Clone for GracefulShutdown. This allows users to use GracefulShutdown in other functions.

@seanmonstar
Copy link
Member

seanmonstar commented Jul 12, 2024 •
edited
Loading

in other functions.

Not that I'm against adding this, but knowing the use cases would help.

There's a part of me that worries if having multiple clones could be confusing when shutdown() consumes self...

@tottoto
Copy link
Contributor Author

tottoto commented Jul 12, 2024

hyperium/tonic#1788 is a use case of this change.

@tottoto tottoto force-pushed the implement-clone-for-gracefulshutdown branch from 32d1c48 to eb6167a Compare July 16, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tottoto @seanmonstar