Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): bytes::Buf wrapper that notifies subscribers on EOS #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(common): bytes::Buf wrapper that notifies subscribers on EOS #6

wants to merge 6 commits into from

Commits on Aug 23, 2022

  1. feat(common): bytes::Buf wrapper that notifies subscribers on EOS

    @tomkarw
    tomkarw committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b99624f View commit details
    Browse the repository at this point in the history

  2. test(common): add basic test for AlertOnEos

    @tomkarw
    tomkarw committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    03f7ca1 View commit details
    Browse the repository at this point in the history

  3. fix(common): replace usage of Notify::notify_waiters with Notify::not… 

    …ify_one
    @tomkarw
    tomkarw committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    e00f6f1 View commit details
    Browse the repository at this point in the history

  4. chore: disable miri for tests

    @tomkarw
    tomkarw committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    5cd09b5 View commit details
    Browse the repository at this point in the history

  5. style: make structs/methods linkable in doc-strings

    @tomkarw
    tomkarw committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    129d901 View commit details
    Browse the repository at this point in the history

  6. refactor(common): make notifier an Option instead of struct + boolean 

    We want to ensure that the notifier is only called once, when writing that earier I tried to force the notifier into an Arc<Option<...>>,
completely forgetting about the ownership-safe and easier Option<Arc<...>>.
    @tomkarw
    tomkarw committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    9150c0f View commit details
    Browse the repository at this point in the history