feat: allow enabling http1/http2 individually #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioBenitez
force-pushed
the
distinct-http-features
branch
from
08a5dd5
to
a4c9186
Compare
seanmonstar
reviewed
Dec 20, 2023
There was a problem hiding this comment.
This could be a way to address hyperium/hyper#3493, if we leave the server-auto feature in. Basically, if you have enabled server and http1, then the auto builder can exist with only the HTTP/1 parts.
What do you think @davidpdrsn?
SergioBenitez
force-pushed
the
distinct-http-features
branch
from
a4c9186
to
d6bea3e
Compare
|
It seems that |
SergioBenitez
force-pushed
the
distinct-http-features
branch
from
d6bea3e
to
653215e
Compare
|
Rebased on master. |
|
@seanmonstar @SergioBenitez any updates?) |
|
@ikrivosheev There's nothing to do on my end. |
SergioBenitez
force-pushed
the
distinct-http-features
branch
from
653215e
to
a6c691f
Compare
SergioBenitez
force-pushed
the
distinct-http-features
branch
from
a6c691f
to
a376675
Compare
|
@seanmonstar What's preventing this from getting in? I really don't want to keep rebasing as changes are made upstream. |
seanmonstar
reviewed
Jan 29, 2024
seanmonstar
approved these changes
Jan 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title. Previously we pulled in just the deps for http1 or just the deps for http2. This reenables that.