-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coordinated openssl version? #175
Comments
The exact version used in a specific project should be manageable via On Wed, Dec 3, 2014, 11:01 PM Artem notifications@github.com wrote:
|
That doesn't work. When I change Cargo.lock and hit the build my changes in the Cargo.lock are overwritten! For example, original: http://pastebin.com/ejcBPnru; change: http://pastebin.com/2F82hpvc; after "cargo test" the Cargo.lock becomes identical to the original one. |
@seanmonstar could hyper change its openssl dependency to use the crates version in order for Cargo to recognize that it's the same version? Steven says the semver should kick in then (sfackler/rust-postgres#87) and everything should work. |
I'm going to try and land crates.io today or tomorrow. |
Great, I'll test then! I might have made a pull request myself but I'm not that familiar with hyper's multi-crate structure. |
We'll probably use version |
You should just use hyper's crates.io version for now, which doesn't include the benchmarks. We are blocked from fully porting over by |
It works, thanks! Hyper is now useable alongside Mysql and Postgresql drivers. |
FWIW the crates.io experience will probably be broken like this until 1.0 since library authors will have to maintain two moving targets (rather than one, post-1.0) |
So, when one project uses a crates version of openssl and another uses a git version, the build using both projects is broken. When one project uses an upstream version and another uses a fixed version (blackbeam/rust-mysql-simple@06edff7), the build using both projects will be broken very soon.
How do we coordinate this?
rust-lang/cargo#1006 will tell us about the issue but it's little help if the issue will resurface every time somebody updates the version in one of the projects.
I'm going to open this bug in multiple projects:
blackbeam/rust-mysql-simple#7
sfackler/rust-postgres#87
The text was updated successfully, but these errors were encountered: