Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the end-to-end, pipeline, and server benchmarks #2930

Closed
2 of 3 tasks
seanmonstar opened this issue Jul 29, 2022 · 5 comments · Fixed by #2934
Closed
2 of 3 tasks

Re-enable the end-to-end, pipeline, and server benchmarks #2930

seanmonstar opened this issue Jul 29, 2022 · 5 comments · Fixed by #2934
Labels
A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone

Comments

@seanmonstar
Copy link
Member

seanmonstar commented Jul 29, 2022

This were disabled as part of #2929, since they depended on HttpConnector or Server::bind. The first two are easier than the last:

  • benches/pipeline.rs
  • benches/server.rs
  • benches/end_to_end.rs
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. labels Jul 29, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone Jul 29, 2022
@seanmonstar seanmonstar reopened this Aug 2, 2022
@Robertoskr
Copy link

I will start with reenabling benches/end_to_end.rs

@seanmonstar
Copy link
Member Author

There's a comment in #2934 about what makes it a little harder, which may help in writing the PR.

@Robertoskr
Copy link

Robertoskr commented Aug 8, 2022

I'm a bit new to open source, i did the changes, but need a bit of help for pushing the branch to this repo, when i try to push i get the following error:

Username for 'https://github.com': robertoskr
Password for 'https://robertoskr@github.com': 
remote: Permission to hyperium/hyper.git denied to Robertoskr.
fatal: unable to access 'https://github.com/hyperium/hyper.git/': The requested URL returned error: 403

Do you have any idea ? @seanmonstar @oddgrd
Already checked all my ssh keys, tokens urls etc... Can be anything related to this repo ?

@seanmonstar
Copy link
Member Author

You can click the "Fork" button at the top right of this page, and then you can git remote add your fork, and then push to it. Once you have a branch in your fork, you can make a pull request referencing it.

@Robertoskr
Copy link

Thank you ! here is the pr: #2937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
Status: Done
2 participants