-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix(benches): re-enable the recently disabled benches #2934
Conversation
I've managed to get all but two of the I've also attached the logs from one of the broken benches (they both get stuck like this). Logs from failing benches
|
0827a22
to
8adf017
Compare
Yes, the |
re-enable the recently disabled pipeline and e2e bench using `hyper::server::conn` instead of the removed higher-level `Server` api
8adf017
to
5ed747f
Compare
Hi, thanks for the tip on the |
Re-enable two of the
benches
disabled in #2929, usinghyper::server::conn
rather than the higher-levelServer
struct which is getting removed.benches/pipeline.rs
benches/server.rs
I tested the updated benches by running them on this branch and also on the commit before #2929, and they have the same performance. I tried to implement graceful shutdown, but I'm not sure how to do it without
Server
. I see there is an issue (#2862) to add a helper for this tohyper-util
, but if it can be implemented without it I am happy to keep trying.PS. I don't have a firm grasp on async yet, so please let me know if I did something weird 😄
Partially closes #2930