Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when pool idle timeout set to zero #2997

Open
Seeker14491 opened this issue Sep 28, 2022 · 0 comments
Open

Panic when pool idle timeout set to zero #2997

Seeker14491 opened this issue Sep 28, 2022 · 0 comments
Labels
C-bug Category: bug. Something is wrong. This is bad!

Comments

@Seeker14491
Copy link

Version
hyper v0.14.20, h2 v0.3.14, tokio v1.21.2

Platform
Linux seekr-xps15-zorin 5.13.0-35-generic #40~20.04.1-Ubuntu SMP Mon Mar 7 09:18:32 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Description
Passing in Some(Duration::ZERO) to hyper::client::Builder::pool_idle_timeout() can lead to a panic. The panic happens in the tokio::time::interval() function, which disallows specifying a zero duration.

I have switched my code to use builder.pool_max_idle_per_host(0) instead, which works properly.
@Seeker14491 Seeker14491 added the C-bug Category: bug. Something is wrong. This is bad! label Sep 28, 2022
0x676e67 added a commit to 0x676e67/hyper that referenced this issue Oct 20, 2023
@0x676e67
fix(client): panic when pool idle timeout set to zero
cc3f251 
From issue: hyperium/hyper#2997
@0x676e67 0x676e67 mentioned this issue Oct 20, 2023
Merged
seanmonstar pushed a commit that referenced this issue Oct 20, 2023
@0x676e67
fix(client): panic when pool idle timeout set to zero (#3365)
34d3800 
From issue: #2997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug. Something is wrong. This is bad!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Seeker14491