http2::handshake() is useless in 1.0 given no default executor
#3128
Labels
B-breaking-change
Blocked: this is an "API breaking change".
C-bug
Category: bug. Something is wrong. This is bad!
Milestone
Comments
conradludgate
changed the title
handshake() helper methods are useless in 1.0 given no default executorhandshake() helper methods are useless in 1.0 given no default executor
conradludgate
changed the title
handshake() helper methods are useless in 1.0 given no default executorhttp2::handshake() is useless in 1.0 given no default executor
|
Good catch, thank you! |
seanmonstar
added
the
B-breaking-change
seanmonstar
pushed a commit
that referenced
this issue
Jan 31, 2023
This commit removes `common::Exec::Default` that just panics when used. We are removing `tokio`, leaving `Exec::Default` with no implementation and panics when `Exec::execute` is called. Since `Exec::Default` has no purpose, it is being removed and user should now provide an implementation of executor. Closes #3128 BREAKING CHANGE: `hyper::client::conn::Http2::Builder::new` now requires an executor argument.
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this issue
Jan 12, 2024
This commit removes `common::Exec::Default` that just panics when used. We are removing `tokio`, leaving `Exec::Default` with no implementation and panics when `Exec::execute` is called. Since `Exec::Default` has no purpose, it is being removed and user should now provide an implementation of executor. Closes hyperium#3128 BREAKING CHANGE: `hyper::client::conn::Http2::Builder::new` now requires an executor argument.
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this issue
Jan 16, 2024
This commit removes `common::Exec::Default` that just panics when used. We are removing `tokio`, leaving `Exec::Default` with no implementation and panics when `Exec::execute` is called. Since `Exec::Default` has no purpose, it is being removed and user should now provide an implementation of executor. Closes hyperium#3128 BREAKING CHANGE: `hyper::client::conn::Http2::Builder::new` now requires an executor argument. Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
hyper 1.0.0-rc2
Description
hyper::client::conn::http2::handshake(io).awaitcauses an instant panic. Internally it performsBuilder::new().handshake(io).awaitwhich uses theExec::Defaultexecutor. There is no longer a defaulttokioruntime implied since the removal of theruntimefeature.https://github.com/hyperium/hyper/blob/master/src/common/exec.rs#L36-L38
There is a TODO in this file to refactor executors. But I couldn't find a relevant issue, so I wanted to open one to ensure this doesn't get included in the official release
The text was updated successfully, but these errors were encountered: