Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving less common headers into another crate #317

Closed
reem opened this issue Feb 14, 2015 · 4 comments
Closed

Consider moving less common headers into another crate #317

reem opened this issue Feb 14, 2015 · 4 comments
Labels
A-headers Area: headers.

Comments

@reem
Copy link
Contributor

reem commented Feb 14, 2015

These headers come with undesirable properties, like additional dependencies, which might not be ideal for the core hyper repo. If we somehow isolated them and hyper itself, I think it would lead to more stability. This might not be a concern since 1.0 is soon and things should hopefully chill out.

@reem reem added the A-headers Area: headers. label Feb 14, 2015
@pyfisch
Copy link
Contributor

pyfisch commented Mar 1, 2015

I propose to keep them in hyper but to make them opt-in using cargo features.

There could be the following groups of opt-in header fields:

The headers folder can be reorganised to represent the optional header fields. We can discuss if any of these groups should be included in the default compilation. There are still some non-essential header fields that remain in default like Server or Referer, maybe we can also make them optional.

@seanmonstar
Copy link
Member

I don't think this is much of a problem.

On Sun, Mar 1, 2015, 5:36 AM Pyfisch notifications@github.com wrote:

I propose to keep them in hyper but to make them opt-in using cargo
features.

There could be the following groups of opt-in header fields:

The headers folder can be reorganised to represent the optional header
fields. We can discuss if any of these groups should be included in the
default compilation. There are still some non-essential header fields that
remain in default like Server or Referer, maybe we can also make them
optional.


Reply to this email directly or view it on GitHub
#317 (comment).

@soc
Copy link

soc commented Mar 24, 2016

I just experienced this. For simple use-cases like "download this file" the dependencies of cookies are really unfortunate.

Cookies depends on various unicode libraries, and unicode stuff is quite large due to the need of a lot of code and/or data to handle all the rules.

@seanmonstar
Copy link
Member

@soc The only dependency in cookie that would bring in unicode stuff is url, and that is already a dependency of hyper.


If there are specific headers that don't belong in hyper because practically no one uses them, I'd approve their removal. However, I'm going to close this issue because of its broadness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-headers Area: headers.
Projects
None yet
Development

No branches or pull requests

4 participants