Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common headers should go in their own submodules #8

Closed
reem opened this issue Sep 6, 2014 · 0 comments · Fixed by #20
Closed

Common headers should go in their own submodules #8

reem opened this issue Sep 6, 2014 · 0 comments · Fixed by #20

Comments

@reem
Copy link
Contributor

reem commented Sep 6, 2014

Instead of being inlined in hyper/header.rs

Since it is very unergonomic to use a Header if it is not implemented, it's also important that basically all common headers have to be implemented here.
reem added a commit to reem/hyper that referenced this issue Sep 8, 2014
@reem
Split common headers into a submodule and into their own files
f2c09c5 
This is a more extensible place to put them and doesn't clutter up
header/mod.rs as much as the old scheme did.

Fixes hyperium#8
@reem reem mentioned this issue Sep 8, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split common headers into a submodule and into their own files reem/hyper
1 participant
@reem