Split common headers into a submodule and into their own files #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more extensible place to put them and doesn't clutter up header/mod.rs as much as the old scheme did. Fixes hyperium#8
reem
force-pushed
the
header-submodules
branch
from
cdd8ba3 to
f2c09c5
Compare
seanmonstar
added a commit
that referenced
this pull request
Sep 8, 2014
Split common headers into a submodule and into their own files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more extensible place to put them and doesn't clutter up
header/mod.rs as much as the old scheme did.
It also doesn't make the export list of hyper::header as enormous and
less prone to collisions by splitting up header-specific stuff into
submodules - for instance the TransferEncoding variants.
Fixes #8