Add performance tests to the test suite

[DemiMarie]

Hyper needs to be fast. It would be useful to have the test suite ensure that performance does not regress.

[seanmonstar]

I would love to have a way to test for performance regressions!

[DemiMarie]

@seanmonstar My thought would be to create a server and client on localhost and benchmark the rate at which they can send messages to each other. In general this will not be accurate, since machines are too different. However, if we do this on for machines that should be fairly consistent (ex. Travis CI) we should be safe.

Alternatively, we can come up with a way for compensating for differences between machines.

[seanmonstar]

It should be possible to put in a file in the 'benches' directory, that
uses both the client and server in a benchmark. I believe that rustc bench
tool includes a way to report the numbers to a file (ratchet?), and then
make a subsequent run fail if the numbers differ by too much. Would just
need a way to let Travis commit that file after a successful merge.

On Tue, Oct 11, 2016, 12:51 AM Demi Marie Obenour notifications@github.com
wrote:

@seanmonstar https://github.com/seanmonstar My thought would be to
create a server and client on localhost and benchmark the rate at which
they can send messages to each other. In general this will not be accurate,
since machines are too different. However, if we do this on for machines
that should be fairly consistent (ex. Travis CI) we should be safe.

Alternatively, we can come up with a way for compensating for differences
between machines.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#928 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADJF8FGg-aQOlU3Yl-NtLbH0mbzGWDTks5qyz_wgaJpZM4KR6lf
.

[sanmai-NL]

@seanmonstar: Or compare benchmarks against the previous revision by rebenching, not committing anything.

[seanmonstar]

There are several benchmarks in the benches directory, and benchmarks internally for smaller functions, so I'm going to close this as completed.