Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(uri): remove parsing condition #1347

Merged
merged 1 commit into from Oct 3, 2017
Merged

refactor(uri): remove parsing condition #1347

merged 1 commit into from Oct 3, 2017

Conversation

nieksand
Copy link
Contributor

@nieksand nieksand commented Oct 3, 2017

Scheme check never true given preceding else if

@nieksand
refactor(uri): remove parsing condition
e9cde6d 
Scheme check never true given preceeding else if
@nieksand
Copy link
Contributor Author

nieksand commented Oct 3, 2017

On line 65 we already do s.contains("://").

So this check on line 93 can never be true.

@seanmonstar seanmonstar merged commit 528afb8 into hyperium:master Oct 3, 2017
@seanmonstar
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nieksand @seanmonstar