Key Headers HashMap with SendStr instead of &'static str #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking keying with SendStr would be best. Keeping the header_name fn |
reem
changed the title
|
@seanmonstar You are right. I've updated the PR and commit. |
This fixes an unsafe transmute that could cause use-after-frees on collision resolution in the headers hash and avoids allocating for cases where it is not necessary. Fixes hyperium#12
seanmonstar
added a commit
that referenced
this pull request
Sep 8, 2014
Key Headers HashMap with SendStr instead of &'static str
kstep
added a commit
to kstep/hyper
that referenced
this pull request
Jan 10, 2015
See also mime.rs/hyperium#14
ayax79
pushed a commit
to ayax79/hyper
that referenced
this pull request
Jan 14, 2015
See also mime.rs/hyperium#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unsafe transmute that could cause use-after-frees
on collision resolution in the headers hash. The new scheme allocates
Strings on insertion, but prevents most allocations on lookup by using
the
equivmethods for querying by &str.Fixes #12