Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from net2 to socket2 #2206

Merged
merged 2 commits into from
May 19, 2020
Merged

Switch from net2 to socket2 #2206

merged 2 commits into from
May 19, 2020

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented May 18, 2020

Closes #2205

@jyn514 jyn514 force-pushed the master branch 3 times, most recently from 1f36f61 to 1312887 Compare May 18, 2020 22:45
net2 was recently deprecated; socket2 is the recommended alternative

Closes hyperium#2205
@jyn514
Copy link
Contributor Author

jyn514 commented May 18, 2020

The doc failure doesn't seem related to this change, maybe it was broken in a recent nightly?

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you!

@seanmonstar seanmonstar merged commit d5b0ee5 into hyperium:master May 19, 2020
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this pull request Jul 26, 2021
net2 was recently deprecated; socket2 is the recommended alternative

Closes hyperium#2205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net2 has been deprecated, use socket2 instead
2 participants