Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply unreachable_pub lint #2400

Merged
merged 5 commits into from Jan 14, 2021
Merged

Apply unreachable_pub lint #2400

merged 5 commits into from Jan 14, 2021

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jan 13, 2021

Closes #2390

@taiki-e
Copy link
Contributor Author

taiki-e commented Jan 13, 2021 •
edited

Oh, actual visibility depends on the features...

seanmonstar
seanmonstar approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit f0ddb66 into hyperium:master Jan 14, 2021
@taiki-e taiki-e deleted the unreachable_pub branch January 14, 2021 18:00
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this pull request Jul 26, 2021
@taiki-e
refactor(lib): apply unreachable_pub lint (hyperium#2400)
772e7d4 
Closes hyperium#2390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint for unreachable_pub
2 participants
@taiki-e @seanmonstar