feat(upgrade): allow http upgrades with any body type #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqmana
changed the title
luqmana
force-pushed
the
generic-upgrade
branch
from
6a2f4e7
to
eb3e0ec
Compare
nox
reviewed
Nov 3, 2021
Allow using `Request<T>`/`Response<T>` for any given T with `upgrade::on` instead of just restricting it to `hyper::Body`.
luqmana
force-pushed
the
generic-upgrade
branch
from
eb3e0ec
to
f7854f3
Compare
|
Np, thanks for merging! What's the policy on getting a release on crates.io? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using
Request<T>/Response<T>for any given T withupgrade::oninstead of just restricting it tohyper::Body.#2086 mentioned moving the upgrades API off of the Body type with part of the motivation being:
But the current API is still restricted to just the
hyper::Bodybody type which seems more strict than it needs to be.