fix(headers): make ConnectionHeader and search for websocket protocol unicase #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes ConnectionHeader case-insensitive since HTTP header field names are case-insensitive.
RFC6455 requires the Upgrade Protocol to search case-insensitively for "websocket". At the moment only lower-case works (I hit this when trying to get Autobahn to work with my websocket library).
Other protocol values may be case-sensitive, however, so ProtocolExt is still a normal case-sensitive String.