Remove stream cargo feature #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
force-pushed
the
remove_stream_cargo_feature
branch
from
ab3d025
to
f855b2e
Compare
seanmonstar
requested changes
Jun 14, 2022
|
Alright, we merged the |
|
Awesome, I'll get to work on solving the remaining issues then. :) |
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on closes issue hyperium#2855
oddgrd
force-pushed
the
remove_stream_cargo_feature
branch
from
3fbb3ef
to
31a8be1
Compare
This was referenced Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
streamcargo feature and any usage ofStream, includingBody::wrap_stream,impl Stream for Bodyandaccept::from_stream.A few tests were broken, and some examples. Quite extensive changes were needed to fix some of them, which I wasn't able to do in this PR. As discussed on Discord I left TODO comments on the remaining broken tests, tagged with the PR number (#2896).
This PR partially fixes issue #2855.