Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove server::http2::Builder::with_executor #3089

Merged
merged 1 commit into from Dec 19, 2022
Merged

Remove server::http2::Builder::with_executor #3089

merged 1 commit into from Dec 19, 2022

Conversation

MrGunflame
Copy link
Contributor

Gets rid of Builder::with_executor as it's already provided in Builder::new.

Closes #3087

@MrGunflame
feat(server): remove http2::Builder::with_executor
7b04749 
removes the Builder::with_executor method as it is already
provided in Builder::new

Closes hyperium#3087

BREAKING CHANGE: removes Builder::with_executor
seanmonstar
seanmonstar approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@seanmonstar seanmonstar merged commit ab59a6f into hyperium:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove server http2 Builder::with_executor method
2 participants
@MrGunflame @seanmonstar