Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the docs of hyper::client::conn::http1::Builder::executor #3090

Merged
merged 1 commit into from Dec 20, 2022
Merged

Correct the docs of hyper::client::conn::http1::Builder::executor #3090

merged 1 commit into from Dec 20, 2022

Conversation

dzvon
Copy link
Contributor

@dzvon dzvon commented Dec 20, 2022

This PR contains 2 changes:

  1. style has been formatted by cargo fmt in src/client/conn/http1.rs, which I think it's fine.
  2. change HTTP2 to HTTP1 in docs of hyper::client::conn::http1::Builder::executor.

Closes #3086

seanmonstar
seanmonstar approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :D

@seanmonstar seanmonstar merged commit 28da8a3 into hyperium:master Dec 20, 2022
@dzvon dzvon deleted the fix-3086 branch December 21, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client http1 Builder::executor docs are for http2
2 participants
@dzvon @seanmonstar