Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add Proxy support #771

Merged
merged 2 commits into from Apr 26, 2016
Merged

feat(client): add Proxy support #771

merged 2 commits into from Apr 26, 2016

Conversation

seanmonstar
Copy link
Member

This works by configuring proxy options on a Client, such as client.set_proxy("http", "127.0.0.1", "8018").

Closes #531

This works by configuring proxy options on a `Client`, such as
`client.set_proxy("http", "127.0.0.1", "8018")`.

Closes #531
@seanmonstar seanmonstar merged commit 3a3e086 into master Apr 26, 2016
@seanmonstar seanmonstar deleted the allow-proxy branch April 26, 2016 19:19
@ishbir
Copy link

ishbir commented Aug 11, 2016

Seems like this merge was undone by d35992d. Was it on purpose?

@seanmonstar
Copy link
Member Author

@ishbir sort of. The commit was on purpose, but the hyper Client won't be doing as much automatically. In 0.10, it's possible to handle proxying completely outside the hyper crate. You can connect to any host, and then the handler can use request.set_uri(RequestUri::AbsoluteUrl(target_url)) which will send a request to the host and proxy it (assuming the host knows how to proxy).

Likewise, to provide proxying to https targets, a Connect type can tunnel to the target host before returning a ready TcpStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants