-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit initial main crate API #1
Comments
Building
Examples: general
Example: Greeter client
Example: Routeguide server
Lib
|
Codegen: anyway to run output through |
Generated clientIt looks like you are exposing |
Generated serverDoes |
What do you think about changing the client API so that instead of let request = tonic::Request::new(HelloRequest {
name: "hello".into(),
});
let response = client.say_hello(request).await?; users could just write let request = HelloRequest {
name: "hello".into(),
};
let response = client.say_hello(request).await?; We could add an async fn #ident(&mut self, request: impl Into<tonic::Request<#request>>) Since all This is admittedly a very minor papercut, but it seems like it would reduce some friction in the APIs that I suspect a new user is most likely to use (and make the basic examples seem simpler!)... Something similar could probably be done for response messages. |
* Rename more tests * Clean up smoke test * fmt * Clean up ci and remove all-features test
The main crate's api needs to be audited, the transport module is still under dev so probably not worth it right now to give that a thorough review but would be nice to get a light review of it.
The text was updated successfully, but these errors were encountered: