feat(transport): Expose tcp keepalive to clients & servers #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zenria! Thanks for opening up a pull request, we much appreciate the contribution! It looks like your PR is fine, but we need to upgrade some other dependencies to get the build green before merging it. I'll try to look at that sometime either today or tomorrow. |
This was referenced Nov 25, 2019
|
Once we get deny working which I think you just need to merge master we can merge this! Thanks! |
* master: Upgrade to `tokio 0.2` (hyperium#163) chore(interop): Update console dep (hyperium#155) Temporarily allow duplicate crossbeam-queue crates (hyperium#153) # Conflicts: # tonic/src/transport/server.rs
|
I've updated my PR so it can merge with current master |
LucioFranco
changed the title
rabbitinspace
pushed a commit
to satelit-project/tonic
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Long running tcp connections (grpc streaming), with very low activity may be silently disconnected if done though firewalls or NAT routers. TCP keepalive fixes this.
Solution
Expose hyper tcp_keepalive api on
EndpointandServer.