Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base64 encode details header #345

Merged
merged 3 commits into from
May 7, 2020
Merged

Conversation

LucioFranco
Copy link
Member

@LucioFranco LucioFranco commented May 7, 2020

Closes #342

Signed-off-by: Lucio Franco luciofranco14@gmail.com

Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@dvshur
Copy link
Contributor

dvshur commented May 7, 2020

Could you try it with Bytes::from_static(&[1])?

Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@LucioFranco LucioFranco changed the title chore: Add integration tests fix: base64 encode details header May 7, 2020
@LucioFranco LucioFranco marked this pull request as ready for review May 7, 2020 16:33
@LucioFranco
Copy link
Member Author

@dvshur should be fixed now.

@LucioFranco LucioFranco merged commit e683ffe into master May 7, 2020
@LucioFranco LucioFranco deleted the lucio/integration-tests branch May 7, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when returning Status with arbitrary Bytes in details
2 participants