-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing MSRV #866
Comments
Yeah, tonic did not previously have a "msrv". I think it probably makes sense to adopt one now. We should follow the msrv that tokio is on. |
I agree that adopting an MSRV is good :) However Tower and Axum both have an MSRV higher than tokio. |
We can likely wait to set a MSRV until tokio reaches this higher MSRV :) Obviously since tower has a higher MSRv then we need to follow that. |
@LucioFranco @davidpdrsn Just noting that tonic is going to have the latest of MSRV of all of its dependencies.
I'm assuming that hyper/h2 are the same as Tokio? But there could be other crates in here that require a higher MSRV. I'm not aware of any way to figure this out programmatically, unfortunately... |
lol fair, this is probably why we don't have one already too 😂 |
When I fixed tower's MSRV a few months ago I just binary searched through the rust versions until I found the lower number that worked 😜 |
Bug Report
Version
0.6.2 - all of them
Platform
Irrelevant
Description
MSRV was previously 1.39, then it switched to 1.56 and later the edition was updated but not the version. This doesn't seem intended.
The CI also doesn't enforce MSRV, and it's not configured in
clippy.toml
.I've previously said I'd like MSRV to be no greater than 1.48.0 but this specific request wasn't explicitly accepted nor denied.
tonic-build
fails to compile on 1.48 due to #805 (it succeeds after patching it), which was cosmetic so hopefully this can be reverted?If 1.48.0 or lower is accepted I'm willing to make a PR to:
clippy.toml
The text was updated successfully, but these errors were encountered: