use internal buffer's Buf impl for codec buffers #1695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The internal buffers within the codec
EncodeBuf
/DecodeBuf
implementations contain what looks like more optimized implementations ofBufMut
/Buf
, which we can take advantage of.Solution
For
DecodeBuf
, we can reuseBytesMut
'scopy_to_bytes
implementation, we just need to also update the length.For
EncodeBuf
, we should be able to just reuse all ofBytesMut
's implementation ofBufMut
, which looks a bit simpler than the default implementation.Out of curiosity, I tried running the benchmarks:
Before:
After: