Allow specifying compression encoding order preference #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jun 14, 2024
CapCap
force-pushed
the
v0.11.x
branch
3 times, most recently
from
dba38a5
to
5cc673b
Compare
djc
reviewed
Jun 18, 2024
Allow specifying compression encoding order
|
@CapCap I ran CI looks like there are some failures, can you address those and then ping me again when its ready for review and CI is passing? thanks |
Merged
djc
reviewed
Jun 21, 2024
| } | ||
| } | ||
|
|
||
| /// Enable a [`CompressionEncoding`]. | ||
| /// Every time an encoding is enabled, it is given the lowest priority: i.e first added, highest priority |
There was a problem hiding this comment.
How about we adopt push_front(), push_back() instead of this?
| None | ||
| } | ||
| }) | ||
| .max_by_key(|(_, priority)| *priority) |
There was a problem hiding this comment.
I'm confused by this. It seems to suggest that we pick the max by priority (which is implemented as index in the array), but in the other comment you said that the array represents highest-to-lowest priority order. So which is it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Although Zstd is significantly more performant (> 5x in our testing), the default chosen encoding remains Gzip when both are enabled. This blocks us from being able to gradually roll out zstd support for existing downstream clients before disabling Gzip entirely.
Solution
This PR introduces a feature that allows for specifying the order of compression encodings. The key changes include:
- Updated EnabledCompressionEncodings to support ordering/prioritizing multiple compression encodings such as Gzip and Zstd.
- Modified the enable function to reorder encodings based on the priority, ensuring the most recently enabled encoding has the lowest priority- i.e "first encoding enabled has the highest priority"
- Added new tests to validate the correct priority ordering of compression encodings settings.
- Make sure GRPC correctly copies this order for each connection as well.
The behavior is now "given a list of supported encodings, I will pick the highest priority one that I support"